Send blueprint disks & datasets to simulated sled agent #8358
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
plotnick
force-pushed
the
sim-disks-from-blueprint
branch
from
a793e4d to
3f2524b
Compare
davepacheco
reviewed
Jun 25, 2025
| blueprint_sleds.insert( | ||
| sled_id, | ||
| BlueprintSledConfig { | ||
| state: SledState::Active, | ||
| sled_agent_generation: Generation::new().next(), | ||
| sled_agent_generation: 4.into(), |
There was a problem hiding this comment.
What's up with this number? I feel like it could use a constant and comment.
| @@ -1775,6 +1758,10 @@ async fn setup_with_config_impl<N: NexusServer>( | |||
| .boxed() | |||
| }), | |||
| ), | |||
| ( | |||
There was a problem hiding this comment.
I'm curious why this had to move to after starting Nexus. This configuration mimics what RSS would normally do, right? And that happens before Nexus starts.
|
|
||
| for sled_agent in self.sled_agents.iter().skip(1) { | ||
| let generation = Generation::from_u32(2); |
There was a problem hiding this comment.
Same -- where's this come from?
Comment on lines
+1132
to
+1133
| let zones = | ||
| once(from_clone!(self.blueprint_zones)).chain(repeat(vec![])); |
There was a problem hiding this comment.
Is this constructing a structure with non-empty zones for the first sled agent and no zones for the others?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #7081, fixes #8222. Tracks disks and datasets added to the blueprint in
nexus-test-utils, and sends them to the appropriate simulated sled-agents.Also adds trivial but successful execution to the
test_blueprint_plannerintroduced in #8287.